[Olsr-dev] another

Peter Tarjan (spam-protected)
Tue Apr 28 19:51:31 CEST 2009


Hi,

I think I've found another little thing to fix in olsrd-0-5-6-r4 when
tested with two machines having two olsr network interfaces each.
In function check_link_status(...) an UNSPEC_LINK neighbor information
can override an ASYM_LINK, just their order in the HELLOLQ packet
matters.

Please consider applying my patch to eliminate this problem:

--- a/src/link_set.c	2009-04-28 17:42:14.952198152 +0000
+++ b/src/link_set.c	2009-04-28 17:42:09.896197962 +0000
@@ -749,7 +749,9 @@
      * Note: If a neigh has 2 cards we can reach, the neigh
      * will send a Hello with the same IP mentined twice
      */
-    if (ipequal(&neighbors->address, &in_if->ip_addr)) {
+
+    if (ipequal(&neighbors->address, &in_if->ip_addr) &&
+        neighbors->link != UNSPEC_LINK) {
       ret = neighbors->link;
       if (SYM_LINK == ret) {
         break;

--
Peter T.




More information about the Olsr-dev mailing list