[Olsr-dev] Bugfix and work on the httpinfo plugin

[Hannes Gredler]

On Mon, Oct 06, 2008 at 11:59:01PM +0200, Bernd Petrovitsch wrote:
| Hi!
| 
| I just pushed http://gredler.at/hg/olsrd/raw-rev/68455a7b4bfa. To quote
| the commit message:
| ----  snip  ----
| This changesets includes:
| - The make ADMIN_INTERFACE variable must be == 1 to be "activated" as specified
|   in the docs.
|   And the C preprocessor #define is set to 0 or 1. So we can use #if (and not
|   #ifdef) to check it. This saves against typos in the variables names.
| - Without the admin_interface, the admin_interface.{c,h} files can be completely
|   ignored. So we do that. We keep #ifdef's inside of the 2 files though.
| - trivial cleanups:
|   - reduced a few lines and using snprintf()s format strings with the
|     snprintf(). Otherwise I regurarly wondered why %% was in the constant
|     strings;-)
|   - remove superflous #include's, added needed ones
|   - save few bytes in the CSS. It is unreadable anyways.
| - Removed code for the dead "lq_wsize" option.
| - a few layout improvements.
| 
| Last but not least and the by far important part as it is a real bugfix:
| - Removed the "for (idx = 0; idx < HASHSIZE; idx++) {" loop around the
|   "OLSR_FOR_ALL_TC_ENTRIES(tc)" loop.
|   Getting a > 11MB (IIRC) HTML file (if one tries it on the FunkFeuer net)
|   didn't make FireFox happy. And reading the same 2 lines lots of times on
|   a 2 node "net" is not better.
|   I think it was forgotten/overseen with the MID-set refactoring.
                   ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^

my bad, thanks for the cleanup. - /hannes