[Olsr-dev] Recursive make considered harmful

[John Hay]

On Thu, Nov 27, 2008 at 03:24:01PM +0100, Bernd Petrovitsch wrote:
> Hi!
> 
> On Thu, 2008-11-27 at 14:46 +0100, Bernd Petrovitsch wrote:
> [...]
> > On Thu, 2008-11-27 at 15:34 +0200, John Hay wrote:
> > > On Thu, Nov 20, 2008 at 09:56:05PM +0100, Bernd Petrovitsch wrote:
> [...]
> > > Ghmf, you do not even mention FreeBSD... :-) I have applied your v2
> [...]
> > > patch and the result is short:
> > > 
> > > ###########################################
> > > dolphin:~/olsrd-666eba3a65c0 > gmake build_all
> > > lib/bmf/local.mk:41: *** "*** BMF Plugin only supported on Linux, sorry!".  Stop.
> > > dolphin:~/olsrd-666eba3a65c0 > gmake
> > > lib/bmf/local.mk:41: *** "*** BMF Plugin only supported on Linux, sorry!".  Stop.
> > > dolphin:~/olsrd-666eba3a65c0 > gmake all
> > > lib/bmf/local.mk:41: *** "*** BMF Plugin only supported on Linux, sorry!".  Stop.
> > > dolphin:~/olsrd-666eba3a65c0 >
> > > ###########################################
> > 
> > a) Can/Did You try
> > http://bernd.petrovitsch.priv.at/olsr-ng/recursive-make-considered-harmful-v2.patch
> >    !/?
> >    The lib/bmf/local.mk shouldn't be included in the first place.
> >    -v1 is buggy in (at least) that part - see the exchanged parameters
> >    to $(foreach ....) - (and I detected it while getting it to work for
> >    Win32).
> 
> Grrrml, it is - as the current version - in the list:
> ----  snip  ----
> include $(foreach dir,bmf dot_draw dyn_gw dyn_gw_plain httpinfo mini nameservice pgraph secure txtinfo,lib/$(dir)/local.mk)
> ----  snip  ----
> It's probably the best solution to simply delete "bmf" there (and all
> others which explicitly are not supported under FreeBSD).
> The other solution is to make the above error a warning. But then I do
> not erally see a reson for OS-dependent lists.
> What was the behaviour before or what makes the most sense?
> 

For now I just removed the error line in lib/bmf/local.mk and then
everything seems to be ok.

The previous behaviour was to just flash a message the bmf is only
supported on linux. The rest was still compiled. Maybe one day if
I need bmf badly enough, I'll look into what is so very linux
specific to it.

About your ldconfig question, I do not think it is really needed.

John
-- 
John Hay -- (spam-protected) / (spam-protected)