[Olsr-dev] kill hna_chgestruct

Hannes Gredler (spam-protected)
Mon Nov 19 13:33:38 CET 2007

On Mon, Nov 19, 2007 at 11:30:59AM +0100, Bernd Petrovitsch wrote:
| Hi all!
| http://bernd.petrovitsch.priv.at/olsr-ng/kill-hna_chgestruct.patch
| (against CVS-HEAD) tackles one of the unnecessary malloc()/free()
| callers.


one suggestion: you may want to convert the HNA prefix-length for IPv4
(which is still a mask, right) to a native prefixlength. (and subsequently
remove the mask2prefix conversion in lq_route.c

| Use at own risk, it produces segmentation violations at my home after
| some time. Sorry, no time to look further into it.
| Of course, feedback and hints, where the bug is, are always welcome!
| Hmm, perhaps I should simply shove the *chgestruct() and
| olsr_free_*_list() function into the .c file where the only users are so
| that profilign runs account the malloc() and free()s in the same
| function.

More information about the Olsr-dev mailing list