[Olsr-dev] CCC-Camp07 Results

[Hannes Gredler]

On Sun, Aug 19, 2007 at 06:12:27PM +0200, Bernd Petrovitsch wrote:
| On Thu, 2007-08-16 at 19:07 +0200, Hannes Gredler wrote:
| > looks good - go for it ! - /hannes
| 
| Does this clash with your ongoing work?

no worries - not at all ... everything i do right now is post-SPF ...
 
| BTW the same reasoning holds for lq_hello_neighbor (though it is not
| seen that often) and the same procedure works for the attached patch for
| me.

again go for it ... 
we have now all this duplicate code-pieces which we ultimately should
get rid off ... its good to see you cleaning those things up ...
 
| The only difference is: the "struct hello_neighbor" has the field "union
| olsr_ip_addr main_address" which is currently left uninitialized.
| Is there any useful value for this (but I have no big problem in leaving
| it uninitialized since it is the current behaviour)?

my understanding is that this should be populated with the originator
as encoded in the hello packet

        Hello-LQ Message (201), originator 193.238.158.230, ttl 1, hop 0
                                ^^^^^^^^^^^^^^^^^^^^^^^^^^
          vtime 88.000s, msg-seq 0xefab, length 156
          hello-time 5.000s, MPR willingness 7
            link-type Unspecified, neighbor-type Symmetric, len 12
              neighbor 193.238.158.166, link-quality 53.73%, neighbor-link-quality 87.84%
            link-type Unspecified, neighbor-type Symmetric-MPR, len 108
              neighbor 193.238.158.4, link-quality 44.71%, neighbor-link-quality 47.84%
              neighbor 193.238.158.40, link-quality 51.76%, neighbor-link-quality 80.78%
              neighbor 193.238.158.43, link-quality 40.00%, neighbor-link-quality 65.88%
              neighbor 193.238.158.151, link-quality 41.96%, neighbor-link-quality 64.71%
              neighbor 193.238.156.245, link-quality 47.84%, neighbor-link-quality 10.98%
              neighbor 193.238.157.133, link-quality 10.98%, neighbor-link-quality 91.76%
              neighbor 193.238.157.142, link-quality 25.88%, neighbor-link-quality 56.86%