[olsr-dev] Topology link quality

[Dries Naudts]

Dear all,

regarding the olsr-quality extension, in file tc_set.c in function 
olsr_tc_update_mprs() the following code snippet can be found:

      COPY_IP(&new_topo_dst->T_dest_addr, &mprs->address);
      new_topo_dst->T_time = GET_TIMESTAMP(msg->vtime*1000);
      new_topo_dst->T_seq = msg->ansn;

          if (olsr_cnf->lq_level > 0)
            {
              new_topo_dst->link_quality = mprs->neigh_link_quality;
              new_topo_dst->inverse_link_quality = mprs->link_quality;
        

              new_topo_dst->saved_link_quality = new_topo_dst->link_quality;
              new_topo_dst->saved_inverse_link_quality =
                new_topo_dst->inverse_link_quality;
            }

Can someone explain why the new_topo_dst->link quality is set equal to 
mprs->neigh_link_quality and vice versa?
IMHO, i think new_topo_dst->link_quality must be set equal to 
mprs->link_quality.  Am I missing something? Can someone clearify this 
for me?


Look for instance at this simple example:


node ip = 10.3.246.1

       *** olsr.org - 0.4.10 (Feb  2 2006) ***

--- 06:54:31.25 ---------------------------------------------------- LINKS

IP address       hyst      LQ     lost   total  NLQ    ETX
10.3.245.1       0.000  0.100  0      20     1.000  10.00 

--- 06:54:31.25 ------------------------------------------------ NEIGHBORS

IP address       LQ     NLQ    SYM   MPR   MPRS  will 
10.3.245.1       0.100  1.000  YES     NO    NO    3  

--- 06:54:31.25 ------------------------------------------------- TOPOLOGY

Source IP addr   Dest IP addr     LQ     ILQ    ETX
10.3.245.1       10.3.246.1       0.098  1.000  10.20


In the topology the link from 10.3.245.1 to 10.3.246.1 states LQ as 
0.098, but IMHO it should be 1.000 and vice versa, not?


Thanks in advance...
Dries Naudts


-- 
Dries NAUDTS

Ghent University - IBBT
Department of Information Technology (INTEC)

Complex Zuiderpoort - Blok C0 (new address!)
Gaston Crommenlaan 8 bus 201
B-9050 Ledeberg

tel.:   +32 (0) 9 33 14974, secr.: +32 (0) 9 33 14901 (new numbers!)
fax :   +32 (0) 9 33 14899 (new number!)
e-mail:  (spam-protected)
WWW:     http://www.ibcn.intec.UGent.be
         http://www.ibbt.be/
__________________________________________