[Olsr-cvs] olsrd-current/lib/dyn_gw_plain/src olsrd_dyn_gw_plain.c, 1.5, 1.6

Bernd Petrovitsch (spam-protected)
Thu Nov 8 23:47:42 CET 2007

Update of /cvsroot/olsrd/olsrd-current/lib/dyn_gw_plain/src
In directory sc8-pr-cvs3.sourceforge.net:/tmp/cvs-serv28726/lib/dyn_gw_plain/src

Modified Files:
Log Message:
Another fat commit:

The main target was:
- Fixed the misleading definition of "v4" in "struct olsr_ip_addr" fom
  "olsr_u32_t" (in network-byteorder!) to "struct in_addr". Lots of
  temporary variables to call inet_ntoa()/inet_ptoa() vanished .....
- declare "int_addr", "int_netmask" and "int_broadaddr" in "struct interface"
  as "struct sockaddr_in" since it is that what we actually want there (and
  it is similar to the IPv6 code).

To get that thoroughly via compiler errors, we get:
- We have now ip4_to_string(), ip6_to_string() and olsr_ip_to_string()
  to print a "struct in_addr", "struct in6_addr" and "union olsr_ip_addr"
  into a string buffer.

Alas, this also annoyed me since ages:
- cleanup: olsr_ip_to_string() and similar non-reentrant functions now must
  get a target buffer. To ease that, there is the "struct ipaddr_str"
  which is large enough for all of them (read: for an IPv6 address). This
  also removes the cyclic buffer there.
  All of these function return a "const char *" which can be directly used
  for printf(3) and friends.

And some cleanups:
- const'ified more functions
- converted the source to UTF-8.
- "struct sig_msg" uses an olsr_u8_t for a byte array (and not "char")
- force the few inline function to always be inlined.
- #ifdef the body of the olsr_print_hna_set() and olsr_print_neighbor_table()
  if nothing is done
- use "inline_avl_comp_ipv4()" in "avl_comp_ipv4()"
- clean up the routes on more signals. Basically we want to do this on all
  signals which terminate the program.
- killed a superflous global buffer in src/main.c

This version was breing since weeks and running for severa day in Vienna's
FunkFeuer net without any noticably problem!

Please report anything that broke!

Index: olsrd_dyn_gw_plain.c
RCS file: /cvsroot/olsrd/olsrd-current/lib/dyn_gw_plain/src/olsrd_dyn_gw_plain.c,v
retrieving revision 1.5
retrieving revision 1.6
diff -C2 -d -r1.5 -r1.6
*** olsrd_dyn_gw_plain.c	19 Aug 2007 20:37:41 -0000	1.5
--- olsrd_dyn_gw_plain.c	8 Nov 2007 22:47:40 -0000	1.6
*** 84,89 ****
    printf("OLSRD dyn_gw_plain plugin by Sven-Ola\n");
!   gw_net.v4 = INET_NET;
!   gw_netmask.v4 = INET_PREFIX;
    has_inet_gateway = 0;
--- 84,89 ----
    printf("OLSRD dyn_gw_plain plugin by Sven-Ola\n");
!   gw_net.v4.s_addr = INET_NET;
!   gw_netmask.v4.s_addr = INET_PREFIX;
    has_inet_gateway = 0;
*** 148,153 ****
  	   (iflags & RTF_UP) &&
  	   (metric == 0) &&
! 	   (netmask == mask->v4) && 
! 	   (dest_addr == net->v4))
              olsr_printf(DEBUGLEV, "INTERNET GATEWAY VIA %s detected in routing table.\n", iface);
--- 148,153 ----
  	   (iflags & RTF_UP) &&
  	   (metric == 0) &&
! 	   (netmask == mask->v4.s_addr) && 
! 	   (dest_addr == net->v4.s_addr))
              olsr_printf(DEBUGLEV, "INTERNET GATEWAY VIA %s detected in routing table.\n", iface);

More information about the Olsr-cvs mailing list