On Mon, 2007-08-27 at 13:33 +0200, Sven-Ola Tuecke wrote:
[...]
> you are right. The formula has a design flaw if you use (LinkQualitySize % 
> 4) != 0. Because we're practical guys, nobody uses such a window size for 
> obvious reasons. Common values are 32, 100 or 128. For example, if you use 
> LQW = 111, I'm not 100% sure if the loss_bitmap stuff is correctly 
> implemented. So I would use something with 0 == (lqw % 8) anyhow.

100 % 8 == 4 BTW.

[...]
> to libmath-float-rounding-errors..? I recommend the attached changes.

I'm not having a problem with rules like "window size % n == 0" but I
think
it would be better to tell the user explicitly that he/she uses an
unsupported
value and force him/her to fix it (and not change it silently). Simply
adding
a log message (if this is "corrected") is IMHO not enough - next to no
one
will see it.

More or less the same holds for the "if we don't find a config file, we
use some
default config" approach in main.c.
I can't find any useful reason to start the daemon with some hard coded
values in a demo/example config - especially with a routing daemon.
I would simply exit() there and be done.

As for FreiFunkFirmware, I think it is safe to assume that the user
interfaces
can be expected to always generate a syntactically correct configuration
file so
this shouldn't hurt anyone.

	Bernd
-- 
Firmix Software GmbH                   http://www.firmix.at/
mobil: +43 664 4416156                 fax: +43 1 7890849-55
          Embedded Linux Development and Services




