<br><br><div class="gmail_quote">On Sat, Apr 10, 2010 at 8:59 PM, Mitar <span dir="ltr"><<a href="mailto:mmitar@gmail.com">mmitar@gmail.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex;">
Hi!<br>
<div class="im"><br>
On Sat, Apr 10, 2010 at 8:10 PM, Markus Kittenberger<br>
<<a href="mailto:Markus.Kittenberger@gmx.at">Markus.Kittenberger@gmx.at</a>> wrote:<br>
> from my point of view, if you would make a patch i would have no real<br>
> problem with it *G<br>
<br>
</div>Ehm. This is adding two lines where all other signal calls are:<br></blockquote><div>we have a public repository, just push it, i guess no one will revert it *G </div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex;">
<div class="im"><br>
signal(SIGUSR1, SIG_IGN);<br>
signal(SIGUSR2, SIG_IGN);<br>
<br>
</div><div class="im">> BUT i have some doubts if 2 signals are really useable for all the various<br>
> plugins,..<br>
> what happens if 2 plugins want to use the same signal?<br>
<br>
</div>Then the last one will prevail when they register their signal handler.<br></blockquote><div> </div><div>yes, and a bad coded plugin might than stop olsrd from even starting? (in theory)</div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex;">
<div class="im"><br>
> i think any plugin that needs user interaction should do this differently<br>
> than with SIGUSRx<br>
<br>
</div>Like? So we have a daemon running and would like simple mechanism of<br>
talking to it. Signals are often used for this.<br></blockquote><div>sure, i would have no doubts if the olsrd core would use the signals *G </div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex;">
<br>
But of course we could always add some abstraction to OLSR. Like<br>
registering some main signal handler which would call plugin's signal<br>
handlers one after the other.<br></blockquote><div>i think when there`s another plugin that wants to use signals aswell this would be something to go for,.. *G</div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex;">
<br>
For now I think it does not hurt if OLSR does not get killed by USR1<br>
and USR2 </blockquote><div>i think so too, </div><div><br></div><div>and as nobody else sade anything,.. </div><div>just do it!</div><div><br></div><div>regards Markus</div></div>