On Sam, 2008-12-06 at 22:18 +0100, Bernd Petrovitsch wrote:
> On Sam, 2008-12-06 at 22:03 +0100, Henning Rogge wrote:
> > On Sat, Dec 6, 2008 at 10:00 PM, Bernd Petrovitsch <bernd@firmix.at> wrote:
> > > On Sam, 2008-12-06 at 17:07 +0100, Henning Rogge wrote:
> > >> On Saturday 06 December 2008 14:26:06 L. Aaron Kaplan wrote:
> > >> > olsrd: src/lq_plugin.c:426: olsr_malloc_hello_neighbor: Assertion `
> > >> > (const char *)h + sizeof(*h) == (const char *)h->linkquality' failed.

Found it now: Yes, the "sizeof" is PSW and should be "offsetof()". And
the code allocating/writing into it must also use that.

> > > In which source does this line exist?
> > lq_plugin.c
> > but only in the "stable" branch... I exchanged the whole problematic
> > sections some time ago for the development branch, but it was a mayor
> > refactoring that was not backported.
> 
> Ah, was that the problems with the "broken alignment due to sizeof()
> instead offsetof()" Sven-Ola hunted down?

It is IMHO.

> Well, that should go into -stable IMHO.

	Bernd
-- 
Firmix Software GmbH                   http://www.firmix.at/
mobil: +43 664 4416156                 fax: +43 1 7890849-55
          Embedded Linux Development and Services



