On Son, 2008-11-16 at 23:18 +0100, Alina Friedrichsen wrote: 
> And here is the patch for the stable branch.
> The last development branch patch was an old version, with no support
> IPv6 v4 mapped addresses in the allowed net/host list, sorry. So here
> the new version for the development branch, too.

Cool.
ad "endian bug in the main olsrd": ACK, "struct in_addr" is in
network-byte order.
Grrrml, it would be nice to have some annotation system like in the
Linux kernel and checkruns with `sparse` or so.

ad "double free bug": I fail to see the bug.

I actually like the s/allowed_net/ip_prefix_list/.
We could eventually kill the struct allowed_net completely if all uses
are converted.

Since I have only pure theoretical knowledge about IPv6 (and that is
pretty limited to the usual basic stuff like formats etc.) but I'm
curious:
----  snip  ---- 
      if(ip_version == AF_INET) {
        memmove(&net.v6.s6_addr[12], &net.v4.s_addr, sizeof(in_addr_t));
        memset(&net.v6.s6_addr[0], 0x00, 10 * sizeof(uint8_t));
        memset(&net.v6.s6_addr[10], 0xff, 2 * sizeof(uint8_t));
        prefix_len += 96;
      }
----  snip  ----
That seems to implement some IPv4-to-IPv6 address mapping.
Is this something somewhat standardized? Are there more "competing"
mapping schemes?
Is there some concensus about IPv4-to-IPv6 address
mapping/interoperation?

	Bernd
-- 
Firmix Software GmbH                   http://www.firmix.at/
mobil: +43 664 4416156                 fax: +43 1 7890849-55
          Embedded Linux Development and Services



