On Fre, 2008-09-05 at 17:27 +0200, Hannes Gredler wrote:
[...]
> asking for review & testing,

The following in src/mid_set.c lo9oks fishy:
----  snip  ----
    /* Adjust pointers to neighbortable-entry in link_set */
    ne_ref_rp_count = replace_neighbor_link_set(nbr_old, nbr_new);
    if (ne_ref_rp_count > 0)

#ifdef DEBUG
      OLSR_PRINTF(2, "MID: Performed %d neighbortable-pointer replacements "
                  "(%p -> %p) in link_set.\n",
		  ne_ref_rp_count, nbr_old, nbr_new);
#endif

    mid_old = olsr_lookup_mid_entry(alias_addr);
    if (mid_old) {
----  snip  ----
Do you actually mean
----  snip  ----
    /* Adjust pointers to neighbortable-entry in link_set */
    ne_ref_rp_count = replace_neighbor_link_set(nbr_old, nbr_new);
#ifdef DEBUG
   if (ne_ref_rp_count > 0) {
      OLSR_PRINTF(2, "MID: Performed %d neighbortable-pointer replacements "
                  "(%p -> %p) in link_set.\n",
                  ne_ref_rp_count, nbr_old, nbr_new);
  }
#endif

    mid_old = olsr_lookup_mid_entry(alias_addr);
    if (mid_old) {
----  snip  ----
or something else?

	Bernd
-- 
Firmix Software GmbH                   http://www.firmix.at/
mobil: +43 664 4416156                 fax: +43 1 7890849-55
          Embedded Linux Development and Services



