On Thu, 2007-10-04 at 12:26 -1000, David Cornejo wrote:
> Hi,
> 
> My employer is going to be using olsrd (on FreeBSD).  We develop
> medical equipment and so need to run all the code used through a QA
> suite which includes a static analysis tool (Coverity Prevent).  I
> would like to modify the code to fix some/all of the defects found and
> commit them to the tree.
> 
> First, is there any objection to this?  If not, then would people

To fix bugs and flaws? Of course not.

> prefer a patch posted for review or should I just commit it (I think I
> still have commit privs on sourceforge) and see what happens?

It depends IMHO.
*BSD-only is not my area of expertise anyways.
For obvious simple fixes it's probably better to just fix and commit
them (with a meaningful commit message).
For more invasive/questionable changes in the core, it's probably better
to post patches as Sven-Ola and Hannes (and others) know more then /me
about the inner working of the protocol as such. But I doubt that a tool
would find any in this class.

> Unfortunately I cannot provide others with access to the defects
> viewer, though I can try and put together a summary if there's

If it's the followup product of the so-called "Stanford checker", I know
how results look like from the Linux kernel mailing list.

> interest.

I can live with patches explaining (if necessary) and fixing them;-)

	Bernd
-- 
Firmix Software GmbH                   http://www.firmix.at/
mobil: +43 664 4416156                 fax: +43 1 7890849-55
          Embedded Linux Development and Services



