On Thu, 2007-10-04 at 13:01 -1000, David Cornejo wrote:
> Think of this like super-lint (the sales person would kill me for this
> description, but it's true).  It catches all the things that lint

It does more as people there program semantics into the beast.

> would plus many others.  If you go to www.coverity.com you can find
> all the docs (unfortunately they require registration, so I can't
> redistribute them).
> 
> For example, in mpr.c:olsr_calculate_mpr(), the variable
> two_hop_covered_count is uninitialized when we get to line 471 where

Sorry, old news:
http://lists.olsr.org/pipermail/olsr-dev/attachments/20070802/e8e96533/attachment.txt
But never got an answer (and forgot it until now;-).

> the return value of add_will_always_nodes() is added to it.  This is
> probably fairly benign, but technically the value of the variable is
> indeterminate when it gets to the += and hence a 'defect'.

ACK, that should be fixed.
It is IMHO also a gcc bug (in several versions) too since gcc is
actually supposed to catch such simple uninitialized variables.

> Actually, if there is interest we could see about getting olsrd added
> to a free service coverity offers to open source projects
> (http://scan.coverity.com).

Why not?

	Bernd
-- 
Firmix Software GmbH                   http://www.firmix.at/
mobil: +43 664 4416156                 fax: +43 1 7890849-55
          Embedded Linux Development and Services



