On Tue, 2007-05-01 at 15:08 -0700, Patrick McCarty wrote:
> Bernd and all,
> 
> First, Several instances of missing semi-colons due to the
> OLSR_PRINTF conversion to a real function popped up during my compile.

More background info: I'm thinking and playing with the "deploy one
coding style" theme/issue. And "indent" cannot handle such
pseudo-statements properly so this change/cleanup was a necessary
prerequisite.

> Patch attached.

Thank you. Applied.

> Second, in src/socket_parser.c Line 197ish was changed recently (rev1.24) from:
>  static struct tms tms_buf;
>  [...]
>  now_times = times(&tms_buf);
> to
>  now_times = times(NULL);

Probably because no one used tms_buf (and glibc and/or the Linux kernel
is usually graceful on passed NULL pointers). However, reading the man
page once more, I find:
----  snip  ----
       On Linux, the buf argument can be specified as NULL,  with  the  result  that  times()  just
       returns  a  function result.  However, POSIX does not specify this behaviour, and most other
       Unix implementations require a non-NULL value for buf.
----  snip  ----
I better readd it anyways with a comment .....

> This compiles but causes a segfault under OpenBSD 4.0 (And I suspect others...)
> (Ran using gdb to figure it out...)
> 
> Would attach a patch, but cvs on sourceforge isn't connecting right now.
> 
> Still haven't tracked down the Bison issue for the cfgparser.. its a
> bit of a PITA.... Other than that.. Builds and runs now, finds
> neighbors and sets up links :)

Hmm, running the bison commandline under ltrace or strace (doea OpenBSD
has these things?) may show something (which fails but shouldn't) but I
won't bet on it.

BTW we are working to get OpenBSD running under qemu. So let's see .....

	Bernd
-- 
Firmix Software GmbH                   http://www.firmix.at/
mobil: +43 664 4416156                 fax: +43 1 7890849-55
          Embedded Linux Development and Services



