On Fri, 2007-04-20 at 07:45 +0200, John Hay wrote:
> On Fri, Apr 20, 2007 at 01:12:26AM +0200, Aaron Kaplan wrote:
> > 
> > On Apr 19, 2007, at 9:38 PM, John Hay wrote:
> > 
> > >Any feedback on this one? Is it ok or not? Will it be committed or
> > >not? :-)
> > >
> > John, I have some feedback. The linux man page says that the return  
> > value does not have to be "1" in case of success. Just > 0
> > 
> > maybe we should change that if to "> 0 " ? To make it clean in more  
> > OSes.
> 
> That is ok with me. I only checked the FreeBSD inet_pton() man page
> and RFCs 2553 and 3493. All are very clear that the return value
> can only be -1, 0 or 1.

I changed/fixed it in CVS-HEAD.
And I reviewed all calls to inet_pton(): If we are checking the return
value, it is <= 0 (in case of an error) or > 0 (if it succeeded).

	Bernd
-- 
Firmix Software GmbH                   http://www.firmix.at/
mobil: +43 664 4416156                 fax: +43 1 7890849-55
          Embedded Linux Development and Services



