On Mon, 2007-03-26 at 11:04 +0200, Hannes Gredler wrote:
[...]
> i have noted that there are several different code-styles
>   in the repository, which make the tree a bit hard to digest.

ACK.

[...]
>   - little/no use of typedefs.

Which is IMHO actually a good thing. No need for another layer of
(syntactic) obfuscation and appending "_type" is IMHO the same effort as
prepending with
"struct " .....

[...]
> what is the right procedure for getting this sorted ?
> meybe add a short doc 'olsrd_code_style.txt' and
> convert in peacemeal fashion ?
> 
> thoughts ?

Some months ago I didn't want to break lots of external patches with an
"indent" run and similar cleanup. But this doesn't hold any more.
In general this topic is somewhat prone to flamewars since coding style
is a quite personal thing.
I'm actually waiting for a result of T. Lopatic promised testing on
Windows. But I have no problem in releasing 0.5.0 as is and possibly
0.5.0.1 if some Win* issues are fixed in a few days/weeks/months.
And then is probably the best time to deploy a coding-style.txt and
enforce it immediately (at least in the core parts and for the "indent"
run + syntactic cleanup. If people maintain plugins mainly outside, e.g.
Bmf- or the Quagga-plugin, it's IMHO their decision).
So if if no one really cares I'm all for a consistent coding style (and
-std=gnu89 or whatever).

	Bernd
-- 
Firmix Software GmbH                   http://www.firmix.at/
mobil: +43 664 4416156                 fax: +43 1 7890849-55
          Embedded Linux Development and Services



