On Mon, 2006-11-27 at 13:48 +0100, Erik Tromp wrote:
> Dear Maintainers of the OLSRD code,
> 
> I would like to propose a few fixes and enhancements to the current OLSR code. The proposed changes are the diff file which can be
> downloaded from http://home.tiscali.nl/levab001/olsrd-0.4.10.diff. The diff's are with respect to the current version 0.4.10, as can
> be downloaded at: http://www.olsr.org/releases/0.4/olsrd-0.4.10.tar.gz
[...]
> * httpinfo plugin:
>   - make IP-addresses clickable
>   - Show ETX value of a HNA route
>   - Show number of MID aliases for each MID entry
>   - Print LQ information only if LQ enabled

Applied.

> * Fix double definition MAX_IFS (16) and MAXIFS (8)
> 
> 
> * Increased MAX_IFS to 32

Will not apply.
Reason: We already got rid of MAX_IFS (and I actually thought that I
removed the last statically sized array of interfaces). So instead I
will also remove that constant and move the nic_states variable into the
struct interface (similar to the struct netbuf).

> * Moved annoying printing of duplicate tables down to debug level 8.

Applied.

For the rest I'm personally not sure which hunks are related to which
fix and which of the fixes must or should be included.
>From the descriptions they all sound reasonable, however I'm not sure if
and how they infere with the changes in FreiFunkFirmware.
Opinions?

	Bernd
-- 
Firmix Software GmbH                   http://www.firmix.at/
mobil: +43 664 4416156                 fax: +43 1 7890849-55
          Embedded Linux Development and Services



