[Olsr-dev] compiler warnings for regex on Android-only

Ferry Huberts (spam-protected)
Wed Jun 20 18:58:53 CEST 2012



On 20-06-12 18:34, Hans-Christoph Steiner wrote:
>
> Hey Ferry,
>
> While I normally am a big believer in fixing compiler warnings, there
> are good times to leave them alone.  The regex code included only for
> Android is one of them.  That code is old, a bit weird, super stable,
> well tested, and working perfectly.  Yes, it makes lots of compiler
> warnings, but it has been that way since 1994, and its included that way
> in Android, OpenBSD, etc.
>
> Please revert your changes to android/regex*

I understand your point.
However, looking at the fixes (again) I see absolutely no reason to 
revert them.

Drowning real warnings in unrelevant warnings is not a preferred way to 
keep olsrd stable.

-- 
Ferry Huberts






More information about the Olsr-dev mailing list